Clean-up search after Marionette upgrade; rearrange nginx folder
#930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial frontend builds were failing after 9f0372e. This updates the babel configuration for correct building.
With recent Marionette changes, View `events` methods are attached before the view is initialized, so debouncing the setQuery function must happen after the event infrastructure is initialized. A separate dev development installation of underscore is also no longer necessary.
View uses pre-rendered content, so child views need to be shown in initialization.
The CollectionView's sort method is what includes the rendering of child views, so we shouldn't overwrite with nothing (if we need a different sorting, we can add a new comparator function later).
By default, the view listens to events on the view's el.
…ng music Temporarily fix an error in volpiano-text alignment whereby missing music that has no accompanying words causes an exception in the process of adjusting missing music spacing to accompanying words. This fix is temporary until the volpiano-display-utilities module is implemented on Cantus Ultimus.
dchiller
changed the title
nginx folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #929.
In addition to various search fixes, this PR reorganizes files in the
nginxcontainer to reduce complexity of the directory structure. Updates build processes to account for this change.