test(e2e): refactor Google Translate with config modes #495
+141
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `blockGoogleTranslate` with `googleTranslateMode` enum - Add three modes: 'block' (default), 'stub', and 'allow' - Add `google-translate-stub.js` to mimic basic GT functionalities - Update GT tests to use 'stub' mode - Non-GT tests now block GT requests entirely - This should make the GT E2E test more stable refs: #494
yinanazhou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blockGoogleTranslatewithgoogleTranslateModeenumgoogle-translate-stub.jsto mimic basic GT functionalitiesrefs: #494
Note
Refactors E2E Google Translate handling to be configurable and stable.
blockGoogleTranslatewithgoogleTranslateModeoption intests/fixtures/pages.tssupporting'block','stub', and'allow'google-translate-stub.js), or allow real scripttests/fixtures/google-translate-stub.jsimplementing minimalgoogle.translate.TranslateElement, cookie-driven lang switching, and deterministic DOM updatestest.use({ googleTranslateMode: 'stub' })Written by Cursor Bugbot for commit 1b62609. This will update automatically on new commits. Configure here.