Tried to stitch lots of images and have to correct some bugs of shift estimation#10
Open
ValeriePineauNoel wants to merge 5 commits intomasterfrom
Conversation
dccote
requested changes
Aug 3, 2022
dccote
left a comment
dccote
left a comment
There was a problem hiding this comment.
One function, one thing: each function must do only one thing. Split the Stitching function into loadImages() and stitchMap()
| #enveloppe = img.correct_intensity_envelop() | ||
|
|
||
| stitch = Stitching(sourceDir=sourcePath, tileD=tileDimensions, imageSize=[1024,512], isIntensityCorrection=True, isMirrored=True, isFlipped=False) | ||
| stitch = Stitching(sourceDir=sourcePath, tileD=tileDimensions, imageSize=[1024,512], isIntensityCorrection=False, isMirrored=True, isFlipped=False) |
There was a problem hiding this comment.
Split the loading of images and the stitching of images in two different functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small modifications to the code to optimize the stitching.