Merged
Conversation
Contributor
Author
|
Part of unblocking: https://github.com/DBCDK/faythe/security/dependabot/30 |
srhb
force-pushed
the
switch-exporter-library
branch
from
6ab3d77 to
50a00a6
Compare
Contributor
Author
|
checks are currently failing due to global github actions degradation, https://www.githubstatus.com/ |
Due to the former being unmaintained and vulnerable, switch the exporter library. I opted for this library and not the official prometheus-client crate because I had trouble figuring out a way to deal with globally available metrics and didn't want to rewrite the entire thing to thread the state through faythe. The whole thing is basically a slight modification to the upstream hyper example at: https://github.com/tikv/rust-prometheus/blob/1d3174bf5ddf056dcb0fe59e06cad4ef42ebec68/examples/example_hyper.rs
srhb
force-pushed
the
switch-exporter-library
branch
from
50a00a6 to
18b8220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prometheus_exporter_base -> prometheus
Due to the former being unmaintained and vulnerable, switch the exporter
library.
I opted for this library and not the official prometheus-client crate
because I had trouble figuring out a way to deal with globally available
metrics and didn't want to rewrite the entire thing to thread the state
through faythe.
The whole thing is basically a slight modification to the upstream hyper
example at:
https://github.com/tikv/rust-prometheus/blob/1d3174bf5ddf056dcb0fe59e06cad4ef42ebec68/examples/example_hyper.rs