Merged
Conversation
…multitask, and thats sloooow also: add .nixos-test-history to .gitignore
Contributor
Author
|
This would probably also raise the confidence in pushing some of the bump/renovate PRs :) 🙏 |
srhb
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It started out as me wanting to improve the file monitor/persister a bit, and then I realized that being able to re-use 90% of the nice NixOS test you wrote for Vault, would be nice.
So, this PR does nothing but add a very simple test of the file_monitor_config and extract most of the code from the Vault test to ./lib.nix so it can be used by both tests.
Note: It also tells your CI to run the test. Hope it's ok.