Open
Conversation
nsarno-lucid
commented
Oct 28, 2025
nsarno-lucid
commented
- A few actor isolation issues cause any project in Xcode 26 to not compile
- I did not test it myself but changes are minimal. We have this package compiling in Imprint but not actively used. We will be using it again in ~1 month and I can QA it then if not merged by then.
- Wrap onPlayerTimeChanged call in MainActor.assumeIsolated since queue: .main guarantees main thread execution - Remove unnecessary await keywords from synchronous updateNowPlayingForSeeking() calls 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Mark play() and pause() as nonisolated with Task dispatch to MainActor to properly handle: - Calls from any thread (main or background) - System controls (MPRemoteCommandCenter) that may execute on non-main threads - MainActor-isolated properties (autoPlay) and methods (beginPlayerObservationIfNeeded) Ensures operations execute in correct order on MainActor while maintaining compatibility with AVPlayer's non-isolated signature. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.