Skip to content

cleanup docs, add post_conversion#6

Merged
d-chambers merged 5 commits intomainfrom
minor_cleanup
Dec 18, 2024
Merged

cleanup docs, add post_conversion#6
d-chambers merged 5 commits intomainfrom
minor_cleanup

Conversation

@d-chambers
Copy link
Contributor

Description

This PR cleans up some of the docstrings/comments and plumbs in the post_conversion method.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test.
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (d9bf709) to head (914a80b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   93.18%   93.61%   +0.42%     
==========================================
  Files           1        1              
  Lines         308      313       +5     
==========================================
+ Hits          287      293       +6     
+ Misses         21       20       -1     
Flag Coverage Δ
unittests 93.61% <100.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit 64e20ba into main Dec 18, 2024
10 checks passed
@d-chambers d-chambers deleted the minor_cleanup branch December 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants