fix #611

[d-chambers]

Description

This PR fixes #611 by dropping coordinates associated with the transform dimension on the stft call. This behavior is consistent with Patch.dft.

Checklist

I have (if applicable):

• referenced the GitHub issue this PR closes.
• documented the new feature with docstrings and/or appropriate doc page.
• included tests. See testing guidelines.
• added the "ready_for_review" tag once the PR is ready to be reviewed.

Summary by CodeRabbit

• Bug Fixes

  • Enhanced coordinate handling in STFT to drop non-dimensional coordinates associated with transformed dimensions, aligning with DFT behavior.

• Documentation

  • Clarified coordinate handling behavior in STFT documentation and tutorials.

• Tests

  • Added test coverage for non-dimensional coordinate handling in STFT operations.

[coderabbitai]

Walkthrough

The changes modify STFT coordinate handling to drop non-dimensional coordinates associated with transformed dimensions. The implementation uses an updated disassociate_coord method, with supporting documentation and test coverage added.

Changes

Cohort / File(s)	Summary
Coordinate Manager Documentation dascore/core/coordmanager.py	Docstring updated for disassociate_coord method to clarify behavior when dropping coordinates associated with specified dimensions.
STFT Transform Implementation dascore/transform/fourier.py, tests/test_transform/test_fourier.py	STFT coordinate generation now uses disassociate_coord to drop non-dimensional coordinates associated with transformed dimensions. New test verifies auxiliary coordinates are correctly removed or retained based on association with transformed dimension.
Tutorial Documentation docs/tutorial/transformations.qmd	Added explanatory note after STFT example documenting that non-dimensional coordinates associated with transformed dimensions are dropped from output, matching DFT behavior.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix #611' is vague and generic, using only an issue reference without describing the actual change or its scope.	Include a descriptive summary of the change, such as 'Drop non-dimensional coordinates on STFT transform' or 'Make STFT coordinate handling consistent with DFT'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description clearly explains the change (dropping coordinates associated with transform dimension), references issue #611, documents the behavior consistency with DFT, and includes a checklist matching the template, though checklist items remain unchecked.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_611

---

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.48%. Comparing base (379ce37) to head (19ef8c3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files         133      133           
  Lines       11483    11483           
=======================================
  Hits        11424    11424           
  Misses         59       59           

Flag	Coverage Δ
unittests	99.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[codspeed-hq]

Merging this PR will not alter performance

✅ 54 untouched benchmarks

---

_{Comparing fix_611 (19ef8c3) with master (379ce37)}