2504 fix CI failures by lifflander · Pull Request #2505 · DARMA-tasking/vt

lifflander · 2026-02-16T23:41:38Z

This fixes two issues;

the format specifiers for the ZoltanLB (conditionally compiled) do not conform to the compile-time specification with the new FMT that VT is now using for all vt_debug_print
Location manager: Fixes the test failure and potential performance issue with cache updates. With this change, we now connect eager location updates to the message’s epoch and send the first update directly back to the original sender, rather than cascading via all the intermediate hops. This fixes the first iteration cache miss (in the test) by ensuring the origin sees the cache update before epoch termination.

github-actions · 2026-02-16T23:43:47Z

clang-format output for this changeset:

diff --git a/src/vt/vrt/collection/balance/zoltanlb/zoltanlb.cc b/src/vt/vrt/collection/balance/zoltanlb/zoltanlb.cc
index ba3b115d5..08cf270f6 100644
--- a/src/vt/vrt/collection/balance/zoltanlb/zoltanlb.cc
+++ b/src/vt/vrt/collection/balance/zoltanlb/zoltanlb.cc
@@ -368,11 +368,8 @@ void ZoltanLB::allocateShareEdgeGIDs() {
       load_comm_edge_id[key] = elm.second;
 
       vt_debug_print(
-        verbose, lb,
-        "allocate: local edge_id={:x}, from={}, to={}\n",
-        key.edge_id_.id,
-        key.fromObj(),
-        key.toObj()
+        verbose, lb, "allocate: local edge_id={:x}, from={}, to={}\n",
+        key.edge_id_.id, key.fromObj(), key.toObj()
       );
 
     } else {
@@ -385,11 +382,8 @@ void ZoltanLB::allocateShareEdgeGIDs() {
         load_comm_edge_id[key] = elm.second;
 
         vt_debug_print(
-          verbose, lb,
-          "allocate: remote edge_id={:x}, from={}, to={}\n",
-          key.edge_id_.id,
-          key.fromObj(),
-          key.toObj()
+          verbose, lb, "allocate: remote edge_id={:x}, from={}, to={}\n",
+          key.edge_id_.id, key.fromObj(), key.toObj()
         );
       } else {
         // The other node will provide the edge
@@ -562,9 +556,7 @@ std::unique_ptr<ZoltanLB::Graph> ZoltanLB::makeGraph() {
         graph->neighbor_idx[edge_idx + 1] = neighbor_idx;
 
         vt_debug_print(
-          verbose, lb,
-          "edge_id={} from={}, to={}\n",
-          iter->first.edge_id_,
+          verbose, lb, "edge_id={} from={}, to={}\n", iter->first.edge_id_,
           iter->first.fromObj(), iter->first.toObj()
         );

github-actions · 2026-02-16T23:46:15Z

Pipelines results

vt-build-amd64-ubuntu-20-04-gcc-10-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-clang-9-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-gcc-12-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-18-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-16-vtk-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-alpine-3-16-clang-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-13-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-10-openmpi-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-gcc-13-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-10-openmpi-cpp-spack

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-gcc-14-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-14-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-12-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-17-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-gcc-12-vtk-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-15-cpp-cxx20

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-icpx-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-ldms-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cuda-11-4-3-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

/vt/src/vt/configs/arguments/args.cc(380): warning: variable "default_vt_memory_reporters" was declared but never referenced

/vt/src/vt/configs/arguments/args.cc(1073): warning: parameter "app" was declared but never referenced

/vt/src/vt/configs/arguments/args.cc(1074): warning: parameter "appConfig" was declared but never referenced

/vt/src/vt/runtime/runtime.cc(1117): warning: parameter "comm" was declared but never referenced

/vt/src/vt/runtime/component/component_pack.impl.h(55): warning: parameter "seq" was declared but never referenced
          detected during:
            instantiation of "std::unique_ptr<T, std::default_delete<T>> vt::runtime::component::<unnamed>::tupleCons<T,Tuple>(Tuple &&) [with T=vt::arguments::ArgConfig, Tuple=std::tuple<std::unique_ptr<vt::arguments::ArgConfig, std::default_delete<vt::arguments::ArgConfig>>>]" 
(104): here
            instantiation of "vt::runtime::component::registry::AutoHandlerType vt::runtime::component::ComponentPack::registerComponent(T **, vt::runtime::component::BaseComponent::StartupDepsPack<StartupDeps...>, vt::runtime::component::BaseComponent::RuntimeDepsPack<RuntimeDeps...>, Cons &&...) [with T=vt::arguments::ArgConfig, StartupDeps=<>, RuntimeDeps=<>, Cons=<std::unique_ptr<vt::arguments::ArgConfig, std::default_delete<vt::arguments::ArgConfig>>>]" 
/vt/src/vt/runtime/runtime.cc(770): here

/vt/src/vt/runtime/component/component_pack.impl.h(55): warning: parameter "tup" was declared but never referenced
          detected during:
            instantiation of "std::unique_ptr<T, std::default_delete<T>> vt::runtime::component::<unnamed>::tupleConsImpl<T,Tuple,I...>(Tuple &&, std::index_sequence<I...>) [with T=vt::util::memory::MemoryUsage, Tuple=std::tuple<>, I=<>]" 
(64): here
            instantiation of "std::unique_ptr<T, std::default_delete<T>> vt::runtime::component::<unnamed>::tupleCons<T,Tuple>(Tuple &&) [with T=vt::util::memory::MemoryUsage, Tuple=std::tuple<>]" 
(104): here
            instan

 ==> And there is more. Read log. <==

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cuda-12-2-0-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

/vt/lib/fmt/include/fmt-vt/base.h(472): warning #128-D: loop is not reachable
    for (; n != 0; ++s1, ++s2, --n) {
    ^
          detected during:
            instantiation of "auto fmt::v11::detail::compare(const Char *, const Char *, std::size_t)->int [with Char=char]" at line 591
            instantiation of "auto fmt::v11::basic_string_view<Char>::compare(fmt::v11::basic_string_view<Char>) const->int [with Char=char]" at line 598
            instantiation of class "fmt::v11::basic_string_view<Char> [with Char=char]" at line 2621
            instantiation of "auto fmt::v11::basic_format_args<Context>::get_id(fmt::v11::basic_string_view<Char>) const->int [with Context=fmt::v11::context, Char=char]" at line 2664

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/fmt/include/fmt-vt/format.h(2596): warning #2417-D: constexpr constructor calls non-constexpr function "fmt::v11::basic_memory_buffer<T, SIZE, Allocator>::basic_memory_buffer(const Allocator &) [with T=fmt::v11::detail::bigint::bigit, SIZE=32UL, Allocator=fmt::v11::detail::allocator<fmt::v11::detail::bigint::bigit>]"
    constexpr bigint() : exp_(0) {}
                                 ^

/vt/lib/fmt/include/fmt-vt/base.h(472): warning #128-D: loop is not reachable
    for (; n != 0; ++s1, ++s2, --n) {
    ^
          detected during:
            instantiation of "auto fmt::v11::detail::compare(const Char *, const Char *, std::size_t)->int [with Char=char]" at line 591
            instantiation of "auto fmt::v11::basic_string_view<Char>::compare(fmt::v11::basic_string_view<Char>) const->int [with Char=char]" at line 598
            instantiation of class "fmt::v11::basic_string_view<Char> [with Char=char]" at line 2621
            instantiation of "auto fmt::v11::basic_format_args<Context>::get_id(fmt::v11::basic_string_view<Char>) const->int [with Context=fmt::v11::context, Char=char]" at line 2664

Remark: The warnings can be suppressed with "-diag-suppress <warning-n

 ==> And there is more. Read log. <==

View job log

vt-build-amd64-ubuntu-22-04-gcc-11-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-clang-10-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-11-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-16-zoltan-cpp

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cpp-docs

Build for c632ff0 (2026-02-17 16:44:26 UTC)

Compilation – successful

Testing – passed

View job log

codecov · 2026-02-17T00:21:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (1eb1658) to head (1cc0618).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2505   +/-   ##
========================================
  Coverage    88.51%   88.51%           
========================================
  Files          728      728           
  Lines        31010    31014    +4     
========================================
+ Hits         27448    27452    +4     
  Misses        3562     3562

Files with missing lines	Coverage Δ
src/vt/topos/location/location.impl.h	`87.17% <100.00%> (-0.93%)`	⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

With this change, we now connect eager location updates to the message’s epoch and send the first update directly back to the original sender, rather than cascading via all the intermediate hops. This fixes the first iteration cache miss in the text by ensuring the origin sees the cache update before epoch termination. This solves a potential performance problem by directly updating from the "deliver node" to the "origin node" avoiding an extra hop and reduces cascaded updates. In most scenarios, this should reduce message counts and stop caches from being polluted.

cwschilly

LGTM

#2504: zoltanlb: fix format specifier

b7bd175

lifflander linked an issue Feb 16, 2026 that may be closed by this pull request

Fix CI failures #2504

Closed

lifflander requested review from cwschilly and nlslatt February 16, 2026 23:41

lifflander added 2 commits February 17, 2026 06:41

#2504: zoltanlb: another fix for format specifier

60e4242

cwschilly approved these changes Feb 17, 2026

View reviewed changes

lifflander merged commit 810d32b into develop Feb 17, 2026
39 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2504 fix CI failures#2505

2504 fix CI failures#2505
lifflander merged 3 commits intodevelopfrom
2504-fix-ci-failures

lifflander commented Feb 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 17, 2026 •

edited

Loading

Uh oh!

cwschilly left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lifflander commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pipelines results

Uh oh!

codecov bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cwschilly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lifflander commented Feb 16, 2026 •

edited

Loading

github-actions bot commented Feb 16, 2026 •

edited

Loading

github-actions bot commented Feb 16, 2026 •

edited

Loading

codecov bot commented Feb 17, 2026 •

edited

Loading