#2479: CI: add ASAN options to always detect leaks and abort on error (non-zero code) by lifflander · Pull Request #2481 · DARMA-tasking/vt

lifflander · 2025-09-24T21:24:12Z

github-actions · 2025-09-24T21:27:28Z

clang-format output for this changeset:

no modified files to format

github-actions · 2025-09-24T21:46:22Z

Pipelines results

vt-build-amd64-alpine-3-16-clang-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-clang-9-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-ldms-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-10-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-16-zoltan-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-10-openmpi-cpp-spack

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-16-vtk-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-icpx-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-gcc-14-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cuda-11-4-3-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::TemperedLB::remoteBlockCountHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::TemperedLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::TemperedLB::remoteBlockCountHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::TemperedLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::TemperedLB, f=&vt::vrt::collection::lb::TemperedLB::remoteBlockCountHandler, Op=vt::collective::

 ==> And there is more. Read log. <==

View job log

vt-build-amd64-ubuntu-22-04-gcc-12-vtk-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-clang-10-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-gcc-13-cpp

Build for ef2ed07 (2025-09-24 21:27:17 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-gcc-12-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-11-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-13-cpp

Build for ef2ed07 (2025-09-24 21:27:17 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-12-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-17-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-15-cpp

Build for ef2ed07 (2025-09-24 21:27:17 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-18-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-14-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cuda-12-2-0-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

/vt/lib/fmt/include/fmt-vt/base.h(472): warning #128-D: loop is not reachable
    for (; n != 0; ++s1, ++s2, --n) {
    ^
          detected during:
            instantiation of "auto fmt::v11::detail::compare(const Char *, const Char *, std::size_t)->int [with Char=char]" at line 591
            instantiation of "auto fmt::v11::basic_string_view<Char>::compare(fmt::v11::basic_string_view<Char>) const->int [with Char=char]" at line 598
            instantiation of class "fmt::v11::basic_string_view<Char> [with Char=char]" at line 2621
            instantiation of "auto fmt::v11::basic_format_args<Context>::get_id(fmt::v11::basic_string_view<Char>) const->int [with Context=fmt::v11::context, Char=char]" at line 2664

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/fmt/include/fmt-vt/format.h(2596): warning #2417-D: constexpr constructor calls non-constexpr function "fmt::v11::basic_memory_buffer<T, SIZE, Allocator>::basic_memory_buffer(const Allocator &) [with T=fmt::v11::detail::bigint::bigit, SIZE=32UL, Allocator=fmt::v11::detail::allocator<fmt::v11::detail::bigint::bigit>]"
    constexpr bigint() : exp_(0) {}
                                 ^

/vt/lib/fmt/include/fmt-vt/base.h(472): warning #128-D: loop is not reachable
    for (; n != 0; ++s1, ++s2, --n) {
    ^
          detected during:
            instantiation of "auto fmt::v11::detail::compare(const Char *, const Char *, std::size_t)->int [with Char=char]" at line 591
            instantiation of "auto fmt::v11::basic_string_view<Char>::compare(fmt::v11::basic_string_view<Char>) const->int [with Char=char]" at line 598
            instantiation of class "fmt::v11::basic_string_view<Char> [with Char=char]" at line 2621
            instantiation of "auto fmt::v11::basic_format_args<Context>::get_id(fmt::v11::basic_string_view<Char>) const->int [with Context=fmt::v11::context, Char=char]" at line 2664

Remark: The warnings can be suppressed with "-diag-suppress <warning-n

 ==> And there is more. Read log. <==

View job log

vt-build-amd64-ubuntu-22-04-gcc-11-cpp

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cpp-docs

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-15-cpp-cxx20

Build for 096c8cd (2025-10-20 14:16:50 UTC)

Compilation – successful

Testing – passed

View job log

codecov · 2025-09-24T22:38:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (5fe1b46) to head (b9859b0).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2481      +/-   ##
===========================================
+ Coverage    88.55%   88.57%   +0.01%     
===========================================
  Files          728      728              
  Lines        31516    31516              
===========================================
+ Hits         27910    27916       +6     
+ Misses        3606     3600       -6

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nlslatt · 2025-10-02T20:38:49Z

docker-bake.hcl


+function "vt_asan_options" {
+  params = [item]
+  result = lookup(item, "vt_asan_options", "detect_leaks=1 abort_on_error=1")


I get more informative leak stack traces when I add the following arguments to this list: fast_unwind_on_malloc=0 malloc_context_size=150 max_stack_depth=0. I'm not sure if all three of these are strictly necessary.

I've added these options. They seem to pick up on the error that was not triggered in this PR

… (non-zero code)

lifflander linked an issue Sep 24, 2025 that may be closed by this pull request

CI does not fail when ASAN fails #2479

Open

3 tasks

nlslatt reviewed Oct 2, 2025

View reviewed changes

lifflander and others added 3 commits October 20, 2025 10:16

#2479: CI: add ASAN options to always detect leaks and abort on error…

4aa2a88

… (non-zero code)

#2479: CI: add ASAN to an openmpi build, switch vt_lb=0 to another build

9b662ea

#2479: output more asan info

b9859b0

cwschilly force-pushed the 2479-ci-does-not-fail-when-asan-fails branch from 23d78b7 to b9859b0 Compare October 20, 2025 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2479: CI: add ASAN options to always detect leaks and abort on error (non-zero code)#2481

#2479: CI: add ASAN options to always detect leaks and abort on error (non-zero code)#2481
lifflander wants to merge 3 commits intodevelopfrom
2479-ci-does-not-fail-when-asan-fails

lifflander commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

nlslatt Oct 2, 2025

Uh oh!

cwschilly Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lifflander commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pipelines results

Uh oh!

codecov bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nlslatt Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

cwschilly Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Sep 24, 2025 •

edited

Loading

codecov bot commented Sep 24, 2025 •

edited

Loading