Skip to content

#2281: Add new allreduce algorithms for Group, Objgroup and Collection#2337

Draft
JacobDomagala wants to merge 70 commits intodevelopfrom
2281-use-a-proper-all-reduce-algorithm-for-groupmanager
Draft

#2281: Add new allreduce algorithms for Group, Objgroup and Collection#2337
JacobDomagala wants to merge 70 commits intodevelopfrom
2281-use-a-proper-all-reduce-algorithm-for-groupmanager

Conversation

@JacobDomagala
Copy link
Member

@JacobDomagala JacobDomagala commented Aug 13, 2024 •
edited
Loading

Fixes #2281 Fixes #2240

@JacobDomagala JacobDomagala self-assigned this Aug 13, 2024
@JacobDomagala JacobDomagala linked an issue Aug 13, 2024 that may be closed by this pull request
Use a proper all-reduce algorithm for GroupManager #2281
Open
@github-actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

Pipelines results

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for ac6da86 (2024-12-10 15:03:31 UTC)

Compilation - successful

Testing - passed

Build log

@JacobDomagala JacobDomagala force-pushed the 2281-use-a-proper-all-reduce-algorithm-for-groupmanager branch 4 times, most recently from ee1a15e to 06165a0 Compare September 3, 2024 17:12
@JacobDomagala JacobDomagala force-pushed the 2281-use-a-proper-all-reduce-algorithm-for-groupmanager branch 3 times, most recently from 11426c1 to 1568c4a Compare September 16, 2024 23:39
@JacobDomagala JacobDomagala force-pushed the 2281-use-a-proper-all-reduce-algorithm-for-groupmanager branch 3 times, most recently from 897f570 to 455829a Compare September 21, 2024 20:46
@JacobDomagala JacobDomagala force-pushed the 2281-use-a-proper-all-reduce-algorithm-for-groupmanager branch from 08113bb to 5523e17 Compare September 26, 2024 17:49
@JacobDomagala JacobDomagala changed the title #2281: Use a proper all reduce algorithm for GroupManager #2281: Add new allreduce algorithms for Group, Objgroup and Collection Sep 27, 2024
@JacobDomagala JacobDomagala mentioned this pull request Sep 27, 2024
Closed
@JacobDomagala JacobDomagala force-pushed the 2281-use-a-proper-all-reduce-algorithm-for-groupmanager branch 3 times, most recently from 164328c to 5c33e20 Compare October 14, 2024 14:40
@cz4rs cz4rs self-requested a review December 4, 2024 15:24
JacobDomagala and others added 29 commits December 10, 2024 07:02
@JacobDomagala @cwschilly
#2281: Make GroupManager and ObjManager also use callback for final h…
7fc0b0e 
…andler (Rabenseifner)
@JacobDomagala @cwschilly
#2281: Working perf test with collection
5ad6779
@JacobDomagala @cwschilly
#2281: Setup perf test for groups and remove the parent proxy, as we …
6caa9ee 
…now store the final handler with callback
@JacobDomagala @cwschilly
#2281: Remove RabenseifnerGroup as we've now integrated groups and co…
8b31099 
…llections into the original struct
@JacobDomagala @cwschilly
#2281: Add unit tests for new callback (BcastCollective)
d32f954
@JacobDomagala @cwschilly
#2281: Refactor Rabensifer a bit so it doesn't require that many temp…
2385cc3 
…late arguments, also let the User specify which algorithm to use
@JacobDomagala @cwschilly
#2281: Implement state holder and use it for Rabenseifner
cab5c61
@JacobDomagala @cwschilly
#2281: Implement clear function for StateHolder that frees dynamic me…
01ec9d7 
…mory allocated for allreduce state
@JacobDomagala @cwschilly
#2281: Working Rabenseifner with updated StateHolder
edbe990
@JacobDomagala @cwschilly
#2281: Typeless Rabensifner and small fixes to StateHolder
d2c8a32
@JacobDomagala @cwschilly
#2281: Typeless RecursiveDoubling and general code refactor/cleanup
9cdcc29
@JacobDomagala @cwschilly
#2281: RecursiveDoubling allreduce - add Collection support
5d47273
@JacobDomagala @cwschilly
#2281: Add unit tests for new Collection allreduce
373ec66
@JacobDomagala @cwschilly
#2281: Small fixes and code cleanup
afb37ee
@JacobDomagala @cwschilly
#2281: Update documentation for new allreduce algorithms
fe39968
@JacobDomagala @cwschilly
#2281: Initial work for AllreduceHolder
605e315
@JacobDomagala @cwschilly
#2281: Fix runtime Kokkos when we run with both device/host memory sp…
a5d0c00 
…aces
@JacobDomagala @cwschilly
#2281: Working AllreduceHolder with all (Collection/Group/ObjGroup) c…
ed00a21 
…omponents
@JacobDomagala @cwschilly
#2281: Fixed runtime issues with StateHolder generating extra ID
d2fd2b0
@JacobDomagala @cwschilly
#2281: Update license and add reduce_op.h file for Kokkos reduce oper…
4ff246d 
…ators
@JacobDomagala @cwschilly
#2281: Always create allreducers for new collective group
c9eeb7a
@JacobDomagala @cwschilly
#2281: New allreducers no longer require Objgroup for internal commun…
e1d47ec 
…ication. This helps for cases when not all Nodes are part of allreduce
@JacobDomagala @cwschilly
#2281: Code refactor and minor bug fixes
47b2013
@JacobDomagala @cwschilly
#2281: Sort out the PendingSends in new allreduce methods
80f6f6a
@JacobDomagala @cwschilly
#2281: Don't use explicit Kokkos::HostSpace for Kokkos::View in Raben…
b2a85d1 
…seifnerMsg and ShouldUseView
@JacobDomagala @cwschilly
#2281: Cleanup StateHolder (move implementation to .cc impl.h files)
2ad52fc
@JacobDomagala @cwschilly
#2281: Resolve issue with incorrect index generated by StateHolder::g…
1a4be39 
…etNextID
@cwschilly
#2281: use or remove unused variables
a37a58e
@cwschilly
#2281: add perf tests for MPI_Allreduce
ac6da86
@cwschilly cwschilly force-pushed the 2281-use-a-proper-all-reduce-algorithm-for-groupmanager branch from 4600310 to ac6da86 Compare December 10, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cz4rs cz4rs Awaiting requested review from cz4rs

At least 1 approving review is required to merge this pull request.

Assignees

@JacobDomagala JacobDomagala

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use a proper all-reduce algorithm for GroupManager Use a proper all-reduce algorithm for ObjGroup

2 participants

@JacobDomagala @cwschilly