Open
Conversation
|
The final value on some gather lines seems highly suspicious. |
|
We also need to be able to specify the |
Contributor
Author
|
Thanks @nlslatt these issues should be fixed now |
Contributor
Author
|
Converting to draft while I work on #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Fixes #12 (wip)
Adds both
doubleandKokkos::complex<double>benchmarks for:Driver Changes
Instead of passing the dimensions of the matrices used for the benchmarks, just specify the number of floating point operations that each benchmark should perform:
Each benchmark will then determine the matrix/vector dimensions so that the operation approximates this number of fp ops.
Detection Script Changes
When running the detection script, specify which benchmark you want to analyze with the following options:
If these flags are not set, the script defaults to
level3anddouble.