Skip to content

#373: Update kokkos and kokkos-kernels to version 4.4.01#374

Draft
thearusable wants to merge 2 commits intodevelopfrom
373-update-kokkos-version
Draft

#373: Update kokkos and kokkos-kernels to version 4.4.01#374
thearusable wants to merge 2 commits intodevelopfrom
373-update-kokkos-version

Conversation

@thearusable
Copy link
Contributor

Closes #373

@thearusable thearusable self-assigned this Sep 26, 2024
@thearusable thearusable marked this pull request as draft September 26, 2024 17:39
@cz4rs cz4rs force-pushed the 373-update-kokkos-version branch from c1a78ef to 5cb4118 Compare October 22, 2024 16:29
@cz4rs
Copy link
Contributor

cz4rs commented Oct 22, 2024

This does NOT remove some code that is specific to older Kokkos versions:

checkpoint  git grep kokkos_version_less
src/checkpoint/container/kokkos_array.h:56:#if KOKKOS_VERSION_LESS(4, 4, 0)
tests/unit/test_footprinter.cc:669:#if KOKKOS_VERSION_LESS(4, 4, 0)
tests/unit/test_footprinter.cc:676:#endif  // KOKKOS_VERSION_LESS(4, 4, 0)
tests/unit/test_kokkos_serialize_pair.cc:76:#if KOKKOS_VERSION_LESS(4, 4, 0)

@cz4rs
Copy link
Contributor

cz4rs commented Oct 24, 2024

This requires updating all "View of Views" according to https://kokkos.org/kokkos-core-wiki/ProgrammingGuide/View.html#i-really-want-a-view-of-views-what-do-i-do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade all workflows to use new version of Kokkos (4.4) and Kokkos Kernels

2 participants