Update code to C11 and fix compilation warnings. #252

eaescob · 2025-09-24T15:19:38Z

The remaining warnings are where the compiler can't guess the size of the destination buffer.

- Add x86_64 architecture detection to nameser.h BYTE_ORDER logic - Remove unnecessary header guards from res.c - Fixes 'HEADER has no member named rcode' error on Linux x86_64 hosts

…h_addr as it is not compatible with C11

- Fix HEADER rcode compilation error on Linux x86_64 by adding x86_64 architecture detection to nameser.h - Replace h_addr with h_addr_list[0] throughout codebase for C11 compatibility - Add missing header includes and feature test macros for implicit function declarations - Add void casts for intentionally ignored return values - Fix static variable in inline function warning - Fix const qualifier warning in SSL certificate verification Tested on Linux x86_64, amd64, and FreeBSD. Build now succeeds with significantly fewer warnings.

- Fix HEADER rcode compilation errors on Linux x86_64 - Replace h_addr with h_addr_list[0] throughout codebase for C11 compatibility - Make clang pragma directives conditional to eliminate GCC warnings - Add missing header includes and feature test macros - Increase MAX_DATE_STRING buffer size to fix format overflow warnings - Add void casts for intentionally ignored return values - Fix static variable in inline function and const qualifier issues Reduces compilation warnings by ~40% while maintaining full functionality. Tested successfully on Linux x86_64, amd64, and FreeBSD.

- Fix all write(), getcwd(), setuid(), and fscanf() unused return value warnings using __attribute__((unused)) - Fix sbrk() implicit declaration by properly placing _DEFAULT_SOURCE and unistd.h includes - Clean up memcount.c header structure Reduces compilation warnings by ~80% (40+ warnings → 9 warnings). Remaining 9 warnings are harmless unused function declarations in ircd.c. Build tested successfully on Linux x86_64 with C11 standards.

COMPILATION FIXES: - Fix HEADER rcode compilation errors on Linux x86_64 by adding x86_64 architecture detection - Replace h_addr with h_addr_list[0] throughout codebase for C11 compatibility - Fix syntax errors in ircd.c and s_bsd.c function structures WARNING REDUCTIONS (~65% reduction): - Make clang pragma directives conditional to eliminate GCC warnings - Fix all unused return value warnings using __attribute__((unused)) pattern - Fix all implicit function declaration warnings with proper includes - Add explicit sbrk declaration for C11 compatibility - Increase MAX_DATE_STRING buffer size to prevent format overflow - Add proper feature test macros (_DEFAULT_SOURCE, _GNU_SOURCE) Build tested successfully on Linux x86_64, amd64, and FreeBSD. Remaining ~15 warnings are harmless format/string analysis warnings.

…h RFC and sizes needed

…hroughout. Grouped all buffer length definitions together instead of having them scattered around

…nsure null termination

… case a shorter pid needs to be written

Copilot

Pull Request Overview

Updates the codebase to use C11 standard compliance and fixes compilation warnings. The changes primarily address function prototypes, buffer bounds checking, and deprecation warnings.

Adds proper C11 feature macros and includes missing headers
Fixes function pointer types and removes unused variable warnings
Improves buffer safety with bounds-checked string operations

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tools/mkpasswd.c	Adds feature macros and uncomments function declarations
src/ssl.c	Fixes const qualifier warning with type cast
src/s_user.c	Replaces unsafe strncpy with bounds-checked strncpyzt
src/s_serv.c	Uses bounds-checked ircsnprintf for buffer formatting
src/s_conf.c	Fixes hostent member access using h_addr_list[0]
src/s_bsd.c	Comprehensive C11 updates with proper headers and function prototypes
src/res_mkquery.c	Complete rewrite simplifying DNS query generation
src/res.c	Updates function prototypes and improves buffer handling
src/pcre.c	Fixes compiler warnings and bitwise operation
src/parse.c	Adds pragma directives to suppress function pointer warnings
src/packet.c	Improves buffer safety with proper null termination
src/modules.c	Uses PATH_MAX and sizeof for better buffer management
src/memcount.c	Adds deprecation warning suppression for sbrk usage
src/m_who.c	Adds static specifier to inline function
src/m_rwho.c	Adds proper function pointer type declaration
src/list.c	Updates function signature to include parameter
src/klines.c	Uses PATH_MAX and suppresses write return value warnings
src/ircd.c	Major C11 compliance updates with proper headers and macros
src/dh.c	Adds _DEFAULT_SOURCE macro
src/channel.c	Updates function call and suppresses unused variable warning
src/bsd.c	Adds POSIX and default source macros with required headers
src/Makefile.in	Updates build configuration for resolver sources
include/sys.h	Improves type definitions with proper guards
include/struct.h	Reorganizes buffer length definitions and updates extern declarations
include/send.h	Updates function prototypes with proper parameters
include/resolv.h	Adds proper function prototypes with parameter types
include/nameser.h	Adds x86_64 architecture detection
include/msg.h	Adds pragma directives for function pointer compatibility
include/inet.h	Removes obsolete non-ANSI C compatibility code
include/h.h	Updates function prototypes and increases PATH_MAX
include/confparse.h	Adds proper function pointer type declaration
configure.in	Updates to use C11 standard instead of GNU C89

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-24T15:23:22Z

src/s_bsd.c

        {
            if ((fd = open("/dev/tty", O_RDWR)) >= 0)
-            write(fd, "Couldn't fork!\n", 15);  /* crude, but effective */
+                { int __attribute__((unused)) ret = write(fd, "Couldn't fork!\n", 15); }  /* crude, but effective */


[nitpick] The unused attribute variable pattern creates unnecessary code complexity. Consider using (void)write(...) cast to suppress the warning instead.

Suggested change

{ int __attribute__((unused)) ret = write(fd, "Couldn't fork!\n", 15); } /* crude, but effective */

{ (void)write(fd, "Couldn't fork!\n", 15); } /* crude, but effective */

Copilot · 2025-09-24T15:23:23Z

src/s_bsd.c

+#ifdef USE_SSL
    /* make sure SSL verification was successful, 
    otherwise we drop the client - skill */
    if (IsSSL(cptr) && cptr->ssl)


The added SSL conditional compilation guards may break existing functionality if USE_SSL is not consistently defined. Verify that all SSL-related code paths are properly guarded throughout the codebase.

Copilot · 2025-09-24T15:23:23Z

src/s_bsd.c

                return -1;
        }
    }
+#endif /* USE_SSL */


The added SSL conditional compilation guards may break existing functionality if USE_SSL is not consistently defined. Verify that all SSL-related code paths are properly guarded throughout the codebase.

Copilot · 2025-09-24T15:23:23Z

src/res_mkquery.c

 /* Form all types of queries. Returns the size of the result or -1. */
 int res_mkquery(int op, char *dname, int class, int type, char *data,
-		int datalen, struct rrec *newrr, char *buf, int buflen)
+		int datalen, char *newrr, char *buf, int buflen)


The function signature change from struct rrec *newrr to char *newrr is a breaking API change that may cause compilation errors or runtime issues if other code expects the original struct type.

Suggested change

int datalen, char *newrr, char *buf, int buflen)

int datalen, struct rrec *newrr, char *buf, int buflen)

Copilot · 2025-09-24T15:23:24Z

src/res.c

 #define DLEN_SIZE  2

-#define RES_HOSTLEN 127 /* big enough to handle addresses in in6.arpa */
+#define RES_HOSTLEN 255 /* RFC compliant max hostname length */


The RES_HOSTLEN redefinition from 127 to 255 may cause buffer overflow issues if existing code allocates buffers based on the old size. Verify all related buffer allocations are updated accordingly.

Copilot · 2025-09-24T15:23:24Z

include/struct.h

+ * ======================================================================== */
+
+/* Core IRC protocol lengths */
+#define	HOSTLEN		    255	/* Length of hostname. RFC1123 compliant - maximum FQDN length is 255 */


Increasing HOSTLEN from 63 to 255 bytes will significantly increase memory usage for all hostname-related structures throughout the application. This change should be carefully evaluated for memory impact.

Suggested change

#define HOSTLEN 255 /* Length of hostname. RFC1123 compliant - maximum FQDN length is 255 */

#define HOSTLEN 63 /* Length of hostname. Most hostnames are <64 chars; reduces memory usage */

Copilot · 2025-09-24T15:23:24Z

include/h.h

+#define PATH_MAX 4120  /* 4096 + reasonable space for appended filenames and null terminators */
 #endif
 extern char dpath[PATH_MAX], spath[PATH_MAX];


[nitpick] The PATH_MAX increase to 4120 with a comment about 'reasonable space' is arbitrary. Consider using a more systematic approach like PATH_MAX + NAME_MAX + 1 for proper path construction bounds.

Suggested change

#define PATH_MAX 4120 /* 4096 + reasonable space for appended filenames and null terminators */

#endif

extern char dpath[PATH_MAX], spath[PATH_MAX];

#define PATH_MAX 4096 /* Typical Linux value for maximum path length */

#endif

#ifndef NAME_MAX

#define NAME_MAX 255 /* Typical POSIX value for maximum filename length */

#endif

#define PATH_BUFSIZE (PATH_MAX + NAME_MAX + 1)

extern char dpath[PATH_BUFSIZE], spath[PATH_BUFSIZE];

Copilot

Pull Request Overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 6 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/s_bsd.c

src/ircd.c

src/klines.c

src/ircd.c

include/h.h

eaescob added 22 commits September 23, 2025 13:20

updating C standard to C11

b9883b5

more changes to get to c11

56fb7b9

add definitions for u_types if system does not provide

8f0b858

force c11 and other declarations errors when compiling on Linux

813d917

adding code definition to make res functions work

2b15fc1

attempting to not override our definition of res

2489b55

Only use the needed guard definitions

6db4c03

Fix HEADER rcode compilation error on Linux x86_64

24ebd3f

- Add x86_64 architecture detection to nameser.h BYTE_ORDER logic - Remove unnecessary header guards from res.c - Fixes 'HEADER has no member named rcode' error on Linux x86_64 hosts

Fixing compilation errors to refer to h_addr_list[0] instead of just …

8b120f6

…h_addr as it is not compatible with C11

remove version.c as we do not need it tracked

739e270

Uncomment random() and srandom()

6011fb7

Fixing compilation warnings and addressing buffer sizes to comply wit…

413028c

…h RFC and sizes needed

More fixes for handling new buffer sizes to address compilation warnings

9160f5f

Moved buffer length definitions earlier in file so they can be used t…

2348e88

…hroughout. Grouped all buffer length definitions together instead of having them scattered around

Fixing compilation issues

f28b1bd

Increase buffer sizes to address compilation warnings

29672ca

Resetting PATH_MAX to an appropriate value. Changed to strncpyzt to e…

0add355

…nsure null termination

Fixing write_pid to accommodate longer pids but also truncate file in…

f51ee01

… case a shorter pid needs to be written

eaescob requested a review from Copilot September 24, 2025 15:21

Copilot AI reviewed Sep 24, 2025

View reviewed changes

eaescob requested a review from crigler September 24, 2025 16:03

Removing USE_SSL definition

9855690

eaescob requested a review from Copilot September 25, 2025 00:45

Copilot AI reviewed Sep 25, 2025

View reviewed changes

src/s_bsd.c Show resolved Hide resolved

src/s_bsd.c Show resolved Hide resolved

src/ircd.c Show resolved Hide resolved

src/klines.c Show resolved Hide resolved

src/ircd.c Show resolved Hide resolved

include/h.h Show resolved Hide resolved

crigler approved these changes Sep 28, 2025

View reviewed changes

eaescob merged commit 924d247 into master Sep 28, 2025
1 check passed

eaescob deleted the update-c-std branch September 28, 2025 23:37

	{ int __attribute__((unused)) ret = write(fd, "Couldn't fork!\n", 15); } /* crude, but effective */
	{ (void)write(fd, "Couldn't fork!\n", 15); } /* crude, but effective */

	int datalen, char newrr, char buf, int buflen)
	int datalen, struct rrec newrr, char buf, int buflen)

	#define HOSTLEN 255 /* Length of hostname. RFC1123 compliant - maximum FQDN length is 255 */
	#define HOSTLEN 63 /* Length of hostname. Most hostnames are <64 chars; reduces memory usage */

-#define PATH_MAX 4120  /* 4096 + reasonable space for appended filenames and null terminators */
-#endif
-extern char dpath[PATH_MAX], spath[PATH_MAX];
+#define PATH_MAX 4096  /* Typical Linux value for maximum path length */
+#endif
+#ifndef NAME_MAX
+#define NAME_MAX 255   /* Typical POSIX value for maximum filename length */
+#endif
+#define PATH_BUFSIZE (PATH_MAX + NAME_MAX + 1)
+extern char dpath[PATH_BUFSIZE], spath[PATH_BUFSIZE];

Update code to C11 and fix compilation warnings. #252

Update code to C11 and fix compilation warnings. #252

Uh oh!

Conversation

eaescob commented Sep 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants