Allow Blocks Order Issue 189 #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow blocks now always in same order as in conf file.
eaescob
reviewed
Apr 5, 2022
Remove current allow blocks too.
A little cosmetic change
eaescob
approved these changes
Apr 5, 2022
crigler
suggested changes
May 6, 2022
Contributor
crigler
left a comment
crigler
left a comment
There was a problem hiding this comment.
It looks like remove_allows makes every struct Client's user->allow field become a dangling pointer to a now-freed entry from the old allows list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow blocks now always in same order as in conf file.