Fix cable shape cache having cache collisions #1591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are two cables with different shapes but identical connections and the same parts (but placed on different sides), cache collision will occur, with both shapes having the same cache key, but different collision shapes. This results in ghost collisions when playing in single player and collision desync between server and the client on dedicated servers.
Example of two cable blocks having different shapes but same cache key, resulting in them having the same shape. Notice how on the second part the collision box on the left should not logically exists, but is shown due to the bug mentioned.