Merged
Conversation
Haruma-K
approved these changes
Sep 11, 2025
qua-iy
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#81 への対応
再現
Unity6 + AAS v2.7.2 で確認 (おそらく2.4.1以上で発生？)
AddressableAssetGroupウインドウを開いた状態で、SmartAddresserのルール適用すると発生
原因
AASにGroupの並び替え機能がついたのに関連して、AddressableAssetSettings.OnModificationに登録された処理からAssetDatabase.SaveAssetが呼ばれるようになった。
(AddressableAssetsSettingsGroupTreeView.SerializeState関数内)
これにより、OnPostprocessAllAssetsでルール適用時にOnModificationを呼び出すところからループが発生していた。
対応
ルール適用前後でAASのハッシュを比較し、変化があった場合だけOnModificationの呼び出しを行うようにした。