Bump 3rdparty/symcrypt_engine/SymCrypt-OpenSSL from 2962228 to 948a1dd
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [3rdparty/symcrypt_engine/SymCrypt-OpenSSL](https://github.com/microsoft/SymCrypt-OpenSSL) from `2962228` to `948a1dd`. - [Release notes](https://github.com/microsoft/SymCrypt-OpenSSL/releases) - [Commits](microsoft/SymCrypt-OpenSSL@2962228...948a1dd) --- updated-dependencies: - dependency-name: 3rdparty/symcrypt_engine/SymCrypt-OpenSSL dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Author
|
Superseded by #8. |
dependabot
bot
deleted the
dependabot/submodules/3rdparty/symcrypt_engine/SymCrypt-OpenSSL-948a1dd
branch
CyanDevs
added a commit
that referenced
this pull request
Jan 5, 2023
4520: Fix bors builds r=CyanDevs a=CyanDevs Multibranch pipelines (which Bors runs as) behave a bit differently than manually triggered pipelines in terms of parameters. 1. It does not specify user-defined parameters. If there are any user-defined parameters, then use the defaults. E.g. `params.BRANCH_NAME` or `$BRANCH_NAME` in shell would be master. 2. To differentiate between different branch in a multibranch pipeline job, an environment variable `BRANCH_NAME` is used and is normally referred to as `env.BRANCH_NAME` or `$BRANCH_NAME` in shell. The problem is both user-defined parameters and Groovy variables are loaded into environment as environment variables (thanks to workflow-cps-plugin) and there is an order of precedence. Point #1 became relevant as user-defined parameters were added to the declarative pipeline in [my last PR](https://github.com/openenclave/openenclave/pull/4505/files#diff-917491029f94ac1ce6c114a542d2a8738ce1f2d1e866eaffe7189d2139250200)). Specifically the user-defined parameter param.BRANCH_NAME took precedence over Groovy variable BRANCH_NAME when loaded into the environment. Therefore both env.BRANCH_NAME, params.BRANCH_NAME, and BRANCH_NAME all referred to the same variable and led to Bors always checking out `master`. This PR fixes the Bors builds by renaming conflicting parameter name, and prefixing global Groovy variables with `GLOBAL_` to be more explicit. So `GLOBAL_BRANCH_NAME` will be set by `env.BRANCH_NAME` (point #2), or if that does not exist, the user-defined parameter `params.BRANCH` (point #1). As a side issue, this also changes `REPOSITORY_NAME`, `DOCKER_TAG` and `FULL_TEST_SUITE` to solely a user-defined parameter. Signed-off-by: Chris Yan <chrisyan@microsoft.com> Co-authored-by: Chris Yan <chrisyan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps 3rdparty/symcrypt_engine/SymCrypt-OpenSSL from
2962228to948a1dd.Commits
948a1ddIntercept stitched AES-CBC + HMAC ciphers and disable them (#50)a44b1eaMerge pull request #49 from microsoft/mitchl-dbg-flagb0da23aDo not set -DDBG=1 when build type is RelWithDebInfo6e95a78Use new SymCrypt flags to specify asymmetric key purposes (#48)b1e5905Avoid redundant EC_KEY tests on key generation (#45)055d83bEnsure method flags are compatible with FIPS mode OpenSSL (#46)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)