move module export declarations to the module file and clean up #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stef-2
commented
Jul 12, 2025
|
|
||
| struct Nullopt {}; | ||
| VKFW_CONSTEXPR Nullopt nullopt = {}; | ||
| VKFW_CONSTEXPR VKFW_INLINE Nullopt nullopt = {}; |
Author
There was a problem hiding this comment.
constexpr implies static here and thus gives this symbol internal linkage, making it non-exportable, marking it as inline fixes this.
Owner
There was a problem hiding this comment.
Can I please have this as a separate commit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my testing, this works with clang, gcc 15 and gcc 16. Hopefully I did not skip exporting any symbols from the header file.