Open
Conversation
Collaborator
|
I really don't like setting some random fields to 0 for actual players. That might cause some weird issues that are impossible to debug, especially on modded servers. Shouldn't it be possible to create a new instance of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When initially adding the feature of setting the xp cooldown of any player, the method of resolving the desired field to achieve this functionality has been rather poor because of the complexity of finding this exact integer field via reflections.
This pull request aims to fix this issue by using the experience orb class to call the players class to change the xp cooldown integer. This change can the be detected and therefore the xp cooldown field be identified.
This code has been tested on Spigot 1.8.8