views again...

Author: BlueWitherer

README.md

@@ -64,9 +64,9 @@ class $modify(MyPlayLayer, PlayLayer) {
 
     // a vanilla hook
     void setupHasCompleted() {
-        // do insane stuff with my option!
-
         PlayLayer::setupHasCompleted();
+
+        // do insane stuff with my option!
     };
 };
 ```

about.md

@@ -60,9 +60,9 @@ class $modify(MyPlayLayer, PlayLayer) {
 
     // a vanilla hook
     void setupHasCompleted() {
-        // do insane stuff with my option!
-
         PlayLayer::setupHasCompleted();
+
+        // do insane stuff with my option!
     };
 };
 ```

include/Horrible.hpp

@@ -116,7 +116,7 @@ namespace horrible {
          * @param id The ID of the option to set the delegate for
          * @param callback The hook callback to register for this option's delegate
          */
-        void addDelegate(std::string id, geode::Function<void(bool)>&& callback);
+        void addDelegate(geode::ZStringView id, geode::Function<void(bool)>&& callback);
 
         /**
          * Returns a reference to the array of all registered categories
@@ -132,7 +132,7 @@ namespace horrible {
      * @param id The ID of the option to delegate for
      * @param hooks The map of hooks to delegate
      */
-    AWCW_HORRIBLE_API_DLL void delegateHooks(std::string id, geode::utils::StringMap<std::shared_ptr<geode::Hook>>& hooks);
+    AWCW_HORRIBLE_API_DLL void delegateHooks(geode::ZStringView id, geode::utils::StringMap<std::shared_ptr<geode::Hook>>& hooks);
 };
 
 // Statically register an option

src/classes/ui/src/SpamChallenge.cpp

@@ -32,7 +32,7 @@ bool SpamChallenge::init() {
     setID("spam-jumps"_spr);
 
     // increase spam target for mobile players
-    m_impl->m_inputTarget = randng::get(50, 20) * ((GEODE_PLATFORM_TARGET & PlatformID::Mobile) ? 2 : 1);
+    m_impl->m_inputTarget = randng::get(50, 20) * ((GEODE_PLATFORM_TARGET & Platform::Mobile) ? 2 : 1);
 
     auto const winSize = CCDirector::get()->getWinSize();
 

src/hooks/Mock.cpp

@@ -19,8 +19,8 @@ inline static Option const o = {
     SillyTier::Medium,
     false,
     {
-        PlatformID::Windows,
-        PlatformID::Android,
+        Platform::Windows,
+        Platform::Android,
     },
 };
 HORRIBLE_REGISTER_OPTION(o);

src/include/Horrible.cpp

@@ -30,7 +30,7 @@ void OptionManager::registerOption(Option option) {
     };
 };
 
-void OptionManager::addDelegate(std::string id, Function<void(bool)>&& callback) {
+void OptionManager::addDelegate(ZStringView id, Function<void(bool)>&& callback) {
     auto& thisDelegate = m_delegates[id];
     thisDelegate.push_back(std::move(callback));
 };
@@ -81,7 +81,9 @@ OptionManager* OptionManager::get() noexcept {
     return inst;
 };
 
-void horrible::delegateHooks(std::string id, utils::StringMap<std::shared_ptr<Hook>>& hooks) {
+void horrible::delegateHooks(ZStringView id, utils::StringMap<std::shared_ptr<Hook>>& hooks) {
+    log::debug("Attempting to delegate {} hooks for option {}", hooks.size(), id);
+
     if (auto om = OptionManager::get()) {
         auto value = om->getOption(id);
 
@@ -95,11 +97,14 @@ void horrible::delegateHooks(std::string id, utils::StringMap<std::shared_ptr<Ho
         log::debug("Delegating {} hooks for {}", allHooks.size(), id);
 
         om->addDelegate(
-            std::move(id),
-            [allHooks = std::move(allHooks)](bool value) {
+            id,
+            [allHooks = std::move(allHooks), id](bool value) {
                 for (auto hook : allHooks) (void)hook->toggle(value);
+                log::debug("Toggled {} hooks {} for option {}", allHooks.size(), value ? "ON" : "OFF", id);
             }
         );
+    } else {
+        log::error("Failed to get OptionManager to delegate hooks for option {}", id);
     };
 };