guess im copying again

Author: BlueWitherer

include/Horrible.hpp

@@ -89,7 +89,7 @@ namespace horrible {
          *
          * @returns A result possibly containing the option object
          */
-        [[nodiscard]] geode::Result<horrible::Option> getOptionInfo(std::string_view id) const noexcept;
+        [[nodiscard]] geode::Result<Option> getOptionInfo(std::string_view id) const noexcept;
 
         /**
          * Returns the amount of delegate callbacks registered for an option
@@ -116,7 +116,7 @@ namespace horrible {
          * @param id The ID of the option to set the delegate for
          * @param callback The hook callback to register for this option's delegate
          */
-        void addDelegate(geode::ZStringView id, geode::Function<void(bool)>&& callback);
+        void addDelegate(std::string id, geode::Function<void(bool)>&& callback);
 
         /**
          * Returns a reference to the array of all registered categories
@@ -132,15 +132,16 @@ namespace horrible {
      * @param id The ID of the option to delegate for
      * @param hooks The map of hooks to delegate
      */
-    AWCW_HORRIBLE_API_DLL void delegateHooks(geode::ZStringView id, geode::utils::StringMap<std::shared_ptr<geode::Hook>>& hooks);
+    AWCW_HORRIBLE_API_DLL void delegateHooks(std::string id, geode::utils::StringMap<std::shared_ptr<geode::Hook>>& hooks);
 };
 
 // Statically register an option
-#define HORRIBLE_REGISTER_OPTION(opt) $execute {\
+#define HORRIBLE_REGISTER_OPTION(opt) \
+$execute { \
     if (auto om = horrible::OptionManager::get()) om->registerOption(opt); \
 }
 
-// Delegate registered hooks to OptionManager for dynamic toggling
+// Delegate hooks to OptionManager for dynamic toggling
 #define HORRIBLE_DELEGATE_HOOKS(id) \
 static void onModify(auto& self) { \
     horrible::delegateHooks(id, self.m_hooks); \

mod.json

@@ -32,9 +32,6 @@
             "resources/*.png"
         ]
     },
-    "dependencies": {
-        "geode.node-ids": ">=1.22.0"
-    },
     "api": {
         "include": [
             "include/*.hpp"

src/hooks/Dementia.cpp

@@ -8,7 +8,7 @@
 using namespace geode::prelude;
 using namespace horrible::prelude;
 
-static Option const o = {
+inline static Option const o = {
     "dementia",
     "Dementia",
     "Chance of the player randomly teleports back. This is more like player lagging to be honest!\n<cy>Credit: imdissapearinghelp</c>",

src/include/Horrible.cpp

@@ -30,7 +30,7 @@ void OptionManager::registerOption(Option option) {
     };
 };
 
-void OptionManager::addDelegate(ZStringView id, Function<void(bool)>&& callback) {
+void OptionManager::addDelegate(std::string id, Function<void(bool)>&& callback) {
     auto& thisDelegate = m_delegates[id];
     thisDelegate.push_back(std::move(callback));
 };
@@ -81,7 +81,7 @@ OptionManager* OptionManager::get() noexcept {
     return inst;
 };
 
-void horrible::delegateHooks(ZStringView id, utils::StringMap<std::shared_ptr<Hook>>& hooks) {
+void horrible::delegateHooks(std::string id, utils::StringMap<std::shared_ptr<Hook>>& hooks) {
     if (auto om = OptionManager::get()) {
         auto value = om->getOption(id);
 
@@ -95,7 +95,7 @@ void horrible::delegateHooks(ZStringView id, utils::StringMap<std::shared_ptr<Ho
         log::debug("Delegating {} hooks for {}", allHooks.size(), id);
 
         om->addDelegate(
-            id,
+            std::move(id),
             [allHooks = std::move(allHooks)](bool value) {
                 for (auto hook : allHooks) (void)hook->toggle(value);
             }