Open
Conversation
- Add Tailwind animation class to improve <GameOver/> UI
- Add Tailwind animation to <GameHeader/> & <PlayButton/> during intro
and <GameControls/> during first question narration
- Improve gameplay with smoother UI/UX
- Add Tailwind animation to <GameDropdownOptions/> to improve UI
- Add fade effects via <transition> to improve UI/UX for game Q&A captions
- Set 'aria-hidden' for parent div with decorative <GameLayout/> icons - Remove unnecessary alt text for SR-hidden image tags
- Add computed property & :classes for current <GameProgressBar/> index - Add transitions/animations to improve UI
jschhie
added
feature
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jschhie
commented
Mar 16, 2026
| :currentQuestion="currentQuestion" | ||
| :showAnswerOnly="showAnswerOnly" | ||
| /> | ||
| <!-- Vue transition wrapper for fade effects --> |
Collaborator
Author
There was a problem hiding this comment.
Notes:
- Added Vue
<transition>wrapper andkeyattributes - (Large diff due to Prettier re-indenting)
Collaborator
Author
|
Hi @master-of-none, Could you please review this whenever you get a chance? It adds Tailwind/Vue animations to improve gameplay transitions. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Approach
animate-fade-slide-in)<transition>wrapper around game Q&A captions components for fade effectscomputedproperty and:classbindings for<GameProgressBar/>to animate progress bar indexaria-hiddenand emptyalt=""text for decorative<GameLayout/>iconsVercel Previews
1.
<GameDropdownOptions/>View
game.zone.menu.dropdown.mov
2. Game Intro UI:
<GameLayout/>+<GameHeader/>+<PlayButton/>View
mobile.small.game.layout.fade.mov
tablet.game.layout.fade.mov
desktop.game.layout.slide.in.mov
3.
<GameControls/>View
game.controls.mov
4.
<GameProgressBar/>+<AnswerCaptions/>View
clip.incorrect.fade.mov
clip.correct.fade.in.out.mov
5.
<GameOver/>View
game.over.mov
Manual Tests