HS ticket #1522768 - Fix to issue: Appeal doesn't display if user preferences is not set or invalid #1567
+107
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setViewModeinAppealsWrapper.tsxis never called unless the user already has a preference set. This leads to a completely blank screen that is confusing for users.Flows, and it does not modify user preferences.NOTE: There seems to be a deeper underlying issue for the particular user in the HS ticket, where their preference may have been set to an invalid value at some point in the application, or their preference was not being persisted by the API. They are not a new user, and so this issue should have never occurred.
HelpScout ticket
Testing
Flowsview should show if the user doesn't already have a preference. You can test this by going toContactsand setting the view toListChecklist:
/pr-reviewcommand locally and fixed any relevant suggestions