[MPDX-9193] Implement salary calculation step 3 #1566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview branch generated at https://9193-salary-calculation-step.d3dytjb8adxkk5.amplifyapp.com |
Contributor
Bundle sizes [mpdx-react]Compared against d3296ef
|
wjames111
approved these changes
Jan 13, 2026
Contributor
wjames111
left a comment
wjames111
left a comment
There was a problem hiding this comment.
This looks really good, didn't find any issues and seems to match the designs well.
Comment on lines
+1
to
+5
| export interface Category { | ||
| label: string; | ||
| amount: number; | ||
| color: string; | ||
| } |
Contributor
There was a problem hiding this comment.
Are we using this in a lot of places, could we just put it in Distribution.tsx?
Contributor
Author
There was a problem hiding this comment.
It's used in the legend, the distribution, and the main card components
canac
force-pushed
the
9193-salary-calculation-step
branch
from
311a578 to
767b4c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Salary Request card was mistakenly on step 4. This PR moves it to step 4 and implements the Request Summary card.
Also includes a few minor fixups on the receipt page - migrating the color and fixing a calculation field typo.
Figma link: https://www.figma.com/design/JInpKB7SkTEcJ3pI3dSzYh/MPDX-8585-Staffweb-migrations-to-MPDX?node-id=7797-12174&m=dev
MPDX-9193
Testing
Checklist:
/pr-reviewcommand locally and fixed any relevant suggestions