MPDX-8856 My MPD Goal Changes

[kegrimes]

Description

Taking over some of Daniel's tasks in T1 - Complete Calculate My MPD Goal:

• MPDX-9143 - Clarify a staff member needs to fill out both tabs; removed tab design and stacked Personal and Financial sections
• MPDX-9144 - Design a way for "Spouse Info" tab to stand out
• MPDX-9145 - Clarification for geographic location
• MPDX-9146 - Ministry Location
• MPDX-9147 - Remove "lump sum" option from "Special Income"
• MPDX-9151 - Added US Conference Staff right panel information
• MPDX-9154 - Added default values for Ministry Expenses (lump sum)

Note: I made the "View Spouse Information" button bold and larger. I'm not sure what else we could do to make it more noticeable. I thought we could add something (like a Chip) that says "currently viewing", but that felt redundant. Ultimately, I think the design looks good. We could add more words to the description, but I know instructions can get overlooked sometimes.

Testing

• Go to /reports/goalCalculator
• Check that each ticket is accounted for

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

[github-actions]

Preview branch generated at https://mpdx-8856-my-mpd-goal-changes.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against 294b1c4

Route	Size (gzipped)	Diff
/accountLists/[accountListId]/reports/goalCalculator/[goalCalculationId]	432.12 KB	-5.58 KB

[kegrimes]

@canac I have a couple questions concerning MPDX-9154.

1. Should a user be able to intentionally set one of the default categories back to 0? Currently, if a user tries to set it to 0 and refresh the page, it will go back to the default.
2. Should the default lump sums also be line items? I think line items are handled in the back end, so I would need to add it there. I think this logic lines up with the current design, so I may just go ahead and start implementing this.

Also, Corey sent me this for the requirements. I don't think I saw a ticket mentioning having columns. Is this something we wanted to do? If so, I am not exactly sure what she means by it.

We had discussed putting "Personal Info" and "Financial Info" one after the other on this page rather than it being two tabs. And for the entire page, having a column for "This Staff" and a second column for "Spouse" so that you could see both in one view.

[canac]

Should a user be able to intentionally set one of the default categories back to 0? Currently, if a user tries to set it to 0 and refresh the page, it will go back to the default.

Yes, I think they should be able to set the default categories back to 0. Which category is resetting back to 0 for you? Are are you talking about production or this PR? I couldn't reproduce in production.

Should the default lump sums also be line items? I think line items are handled in the back end, so I would need to add it there. I think this logic lines up with the current design, so I may just go ahead and start implementing this.

Honestly, I'm not sure. It's going to be easier to make them direct input amounts.

Also, Corey sent me this for the requirements. I don't think I saw a ticket mentioning having columns. Is this something we wanted to do? If so, I am not exactly sure what she means by it.

It sounds like she wants to see the person's personal and financial info in one column and their spouse's in another column, kind of like we are doing for the request forms. I'm not familiar with this work to know whether or not a ticket exists and whether or not we want to implement that. If you're concerned with the scope of work coming from stakeholders, I would talk with Daniel about it. If you're concerned with the UX, you could run it by Ryan.

Is that helpful? We can Huddle if I'm not understanding correctly or if you want to talk through it more.

[canac]

Not a full review, just a couple of quick thoughts from scanning the PR to try to answer your questions.

[kegrimes]

To do:

• Need to add default if role/familySize not set
• Need to add default numbers to line items