-
Notifications
You must be signed in to change notification settings - Fork 1
MPDX-9121 Add Mutations to MHA #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bundle sizes [mpdx-react]Compared against cfa6ff2
|
5ae68fc to
7693cd8
Compare
|
Preview branch generated at https://add-mutations-to-mha.d3dytjb8adxkk5.amplifyapp.com |
wjames111
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for doing all this work! Found a few minor things but nothing serious.
src/components/Reports/MinisterHousingAllowance/EditRequest/EditRequestPage.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/EditRequest/EditRequestPage.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/EditRequest/EditRequestPage.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.graphql
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/DirectionButtons/DirectionButtons.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/DirectionButtons/DirectionButtons.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/StatusCard/StatusCard.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/StatusCard/StatusCard.tsx
Outdated
Show resolved
Hide resolved
dr-bizz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I've been super busy with SIT functionality. I passed this to Will to review. Will will be in on Dec 29th, and you can ask him to review, so I'm not blocking you.
wjames111
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These updates look great! I'm struggling to get it working locally for me though, not sure if I'm missing something.
src/components/Reports/MinisterHousingAllowance/SharedComponents/CurrentBoardApproved.tsx
Show resolved
Hide resolved
|
@wjames111 I am having trouble testing as well because I only have two requests that do not have the statuses I need in order to test. The first one is The current data I am talking about comes from |
wjames111
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes, it looks great! I did notice last I checked there was a failing test. Also this may be a side affect of not being able to update the status but I noticed the create MHA button bugs out a little after an existing MHA is cancelled.
Screen.Recording.2026-01-05.at.9.53.54.AM.mov
...nts/Reports/MinisterHousingAllowance/Shared/Context/MinisterHousingAllowanceContext.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/Steps/StepThree/CalcComponents/CostOfHome.tsx
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/Steps/StepThree/Calculation.tsx
Show resolved
Hide resolved
| if (!effectiveDates) { | ||
| return []; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might remove this block and update effectiveDates to just be an empty array when there's no data?.payrollDates. Should affectively do the same thing but with less code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make this change, but I also don't think I ever edited this file!
| const effectiveDates = data?.payrollDates.map( | ||
| (payrollDate) => payrollDate.regularProcessDate, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const effectiveDates = data?.payrollDates.map( | |
| (payrollDate) => payrollDate.regularProcessDate, | |
| ); | |
| const effectiveDates = data?.payrollDates.map( | |
| (payrollDate) => payrollDate.regularProcessDate, | |
| ) ?? []; |
src/components/Reports/Shared/CalculationReports/PanelLayout/PanelLayout.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/PanelLayout/PanelLayout.tsx
Outdated
Show resolved
Hide resolved
@canac do you have any thoughts on this? |
|
@wjames111 @kegrimes I'd probably update the database directly or use |
|
@dr-bizz Will has already reviewed some of this PR, but I added some mini updates to the MHA here. The process should now be very smooth in between each mutation. To test some changes, you may have to update Changing the View page and print functionality will be done in #1557. |
Description
Add graphQL delete, submit, and duplicate mutations to MHA. Also, updates UI based on new figma designs.
This PR also addresses these issues:
Note: Dialog for past deadline date, pending status, and permission denied components are under review by Ryan and stakeholders.
Testing
/reports/housingAllowanceChecklist:
/pr-reviewcommand locally and fixed any relevant suggestions