feat: Make securityContext configurable, Allow define crowdstrike credentials via secret #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papanito
force-pushed
the
papanito/falcon-self-hosted-registry-assessment-improvements
branch
2 times, most recently
from
516cb20 to
89f9f2b
Compare
papanito
changed the title
Also extend with seccompProfile and capabilities as defaults
papanito
force-pushed
the
papanito/falcon-self-hosted-registry-assessment-improvements
branch
from
89f9f2b to
68a5c84
Compare
Author
|
@mcrowson could you please have a look at this? |
Contributor
|
These generally look good, thanks for the contribution! We'll run some tests with these changes locally and look to incorporate them in a future release. |
Author
|
@mcrowson something missing? would really appreciate to include this change so we can start using the official chart rather than maintaining our own |
Author
|
no one? |
Contributor
|
We're tracking this internally now and hope to have it out with the next release. Date TBD. |
Contributor
|
This was released as part of 1.6.0 https://falcon.crowdstrike.com/support/release-notes/release-notes-self-hosted-registry-assessment-shra-version-1-6-0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.