Skip to content

Conversation

@luans-qa
Copy link
Contributor

Description

Adds unit tests for core wallet operations and refactors the test infrastructure to reduce duplication and improve maintainability.

Changes

New Unit Tests

wallet.test.ts: Unit tests for core Wallet methods
evm.test.ts: Unit tests for EVMWallet methods:
solana.test.ts: Unit tests for SolanaWallet methods:
stellar.test.ts: Unit tests for StellarWallet methods:

Test Infrastructure Refactoring

Created tests/test-helpers.ts: Centralized test utilities:

Test plan

Run $ pnpm test:vitest --run

No TypeScript/linter errors
Tests use fake timers for async polling logic
Comprehensive error handling coverage

Package updates

NA

@luans-qa luans-qa self-assigned this Dec 26, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2025

⚠️ No Changeset found

Latest commit: 7b361ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@albertoelias-crossmint albertoelias-crossmint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving approved with some minor comments and a more overall debate over tests in slack

@luans-qa luans-qa merged commit 549febd into main Dec 26, 2025
2 checks passed
@luans-qa luans-qa deleted the tests/improve-wallets-unit-test-coverage branch December 26, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants