Skip to content

Release 2.0.12 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benwolski merged 5 commits into from
May 7, 2025
Merged

Release 2.0.12 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b23f4b
Fix silently returning an incorrect swap impact result
busimus May 6, 2025
397c61c
update plume network spec
benwolski May 7, 2025
007f174
Merge pull request #76 from CrocSwap/update-plume-network-spec
benwolski May 7, 2025
2b21d81
Merge branch 'develop' into fix-silent-incorrect-impact
benwolski May 7, 2025
fa6462b
Merge pull request #75 from CrocSwap/fix-silent-incorrect-impact
benwolski May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@crocswap-libs/sdk",
"version": "2.0.11",
"version": "2.0.12",
"description": "🛠🐊🛠 An SDK for building applications on top of CrocSwap",
"author": "Ben Wolski <ben@crocodilelabs.io>",
"repository": "https://github.com/CrocSwap/sdk.git",
Expand Down
26 changes: 2 additions & 24 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,26 +168,6 @@ const SCROLL_SEPOLIA_CHAIN: ChainSpec = {
displayName: "Scroll Sepolia",
};

const PLUME_SEPOLIA_CHAIN: ChainSpec = {
nodeUrl: "https://test-rpc.plumenetwork.xyz",
addrs: {
dex: "0x21B5E1aC7154A34d0ae38684A4c27CbE6b9c4f1E",
query: "0x1C74Dd2DF010657510715244DA10ba19D1F3D2B7",
impact: "0x70a6a0C905af5737aD73Ceba4e6158e995031d4B",
},
poolIndex: 36000,
isTestNet: true,
chainId: "0x18230",
gridSize: 1,
proxyPaths: {
cold: 3,
long: 130,
liq: 128
},
blockExplorer: "https://test-explorer.plumenetwork.xyz/",
displayName: "Plume Sepolia",
};

const SWELL_SEPOLIA_CHAIN: ChainSpec = {
nodeUrl: "https://swell-testnet.alt.technology",
addrs: {
Expand Down Expand Up @@ -249,7 +229,7 @@ const PLUME_LEGACY_CHAIN: ChainSpec = {
};

const PLUME_CHAIN: ChainSpec = {
nodeUrl: "https://phoenix-rpc.plumenetwork.xyz",
nodeUrl: "https://rpc.plume.org",
addrs: {
dex: "0xAaAaAAAA81a99d2a05eE428eC7a1d8A3C2237D85",
query: "0x62223e90605845Cf5CC6DAE6E0de4CDA130d6DDf",
Expand All @@ -264,7 +244,7 @@ const PLUME_CHAIN: ChainSpec = {
long: 130,
liq: 128
},
blockExplorer: "https://phoenix-explorer.plumenetwork.xyz/",
blockExplorer: "https://explorer.plume.org/",
displayName: "Plume",
};

Expand Down Expand Up @@ -342,7 +322,6 @@ export const CHAIN_SPECS: { [chainId: string]: ChainSpec } = {
"0x82750": SCROLL_CHAIN,
"0xa0c71fd": BLAST_SEPOLIA_CHAIN,
"0x13e31": BLAST_CHAIN,
"0x18230": PLUME_SEPOLIA_CHAIN,
"0x784": SWELL_SEPOLIA_CHAIN,
"0x783": SWELL_CHAIN,
"0x14a34": BASE_SEPOLIA_CHAIN,
Expand All @@ -357,7 +336,6 @@ export const CHAIN_SPECS: { [chainId: string]: ChainSpec } = {
"scrollsepolia": SCROLL_SEPOLIA_CHAIN,
"blast": BLAST_CHAIN,
"blastSepolia": BLAST_SEPOLIA_CHAIN,
"plumeSepolia": PLUME_SEPOLIA_CHAIN,
"swellSepolia": SWELL_SEPOLIA_CHAIN,
"baseSepolia": BASE_SEPOLIA_CHAIN,
"swell": SWELL_CHAIN,
Expand Down
3 changes: 3 additions & 0 deletions src/swap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ export class CrocSwapPlan {
(this.baseToken.tokenAddr, this.quoteToken.tokenAddr, (await this.context).chain.poolIndex,
this.sellBase, this.qtyInBase, await this.qty, TIP, limitPrice);

if ((impact[0] > 0 && impact[1] > 0) || (impact[0] < 0 && impact[1] < 0))
throw new Error("Invalid impact: base and quote flows have matching signs")

const baseQty = this.baseToken.toDisplay(impact[0] < 0 ? -impact[0] : impact[0])
const quoteQty = this.quoteToken.toDisplay(impact[1] < 0 ? -impact[1] : impact[1])
const spotPrice = decodeCrocPrice(impact[2])
Expand Down