-
-
Notifications
You must be signed in to change notification settings - Fork 61
fix: Fixing timers on GD32 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes the correct logic of the Klipper timer on GD32 series chips
|
@ZeyHex They all have the same MCU: |
If you open the logs (klippy.log) and see something like this, then this PR is definitely for you: |
|
I would certainly like to see this fix merged and tested. @ZeyHex This timer implementation brings the probe accuracy to about 0.002 and would dramatically improve if not fix all the first layer issues. I can't imagine anything more important than resolving this issue. |
@ZeyHex would these warnings usually occur during normal printing, or only during probing only? |
|
@henrivdr they always occur, even just during idle time, if your timers on the MCU are broken. |
@omahena is this improvement seen with the stock prtouchv2? Or does it only work with the full bulk-ADC rework? |
From what I understand this works with the stock PRTouch. @ZeyHex can confirm. I saw this issue debated on Klipper discourse group and am eagerly awaiting for it to be adopted to the official firmware. This improves probing by an order of magnitude and makes the integrated probe fit for the advertised purpose. |
|
Hi! I'm interested in testing this fix on a Creality K1C as well.
Could anyone who has already implemented this fix please verify or share the @ZeyHex Would implementing only Thank you very much for the work that has been done! In my search for a solution to this problem, I have already tried many ways to fine-tune the parameters in In the meantime, I have a ticket open with Creality regarding this issue, and I am waiting for a response from their technical department. |


Fixes the correct logic of the Klipper timer on GD32 series chips