[Backport release/3.36] CAST-38539: Warn and prompt in sat bmccreds for long passwords
#377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to `sat bmccreds` to log a warning if the provided or generated password is longer than 20 characters. This is the maximum password length supported by `ipmitool`, which is required to control management nodes during system boot and shutdown procedures. The warning is logged whenever the password exceeds 20 characters. The user must answer the prompt if it is determined that the affected xnames include management node BMCs or if that can't be determined (i.e. if the HSM query fails, or `--no-hsm-check` is specified). Added unit tests for the new `validate_password_length` method. Test Description: Unit tests pass. Tested the following cases with `sat bmmcreds` on vinland: - User-specified password of an acceptable length against a compute and management node BMC - Too long generated password against a compute and management node BMC - Too long user-specified password against a compute and management node BMC - Too long user-specified password against only compute BMC - Exactly 20-character password against both BMCs - Too long password entered at the prompt against both BMCs (cherry picked from commit b55cf31)
7 tasks
haasken-hpe
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #376