Merged
Conversation
- Simplified the validation logic in CommandForm to ensure isValid is driven exclusively by silentValidationResult. - Removed unnecessary field validity tracking and user interaction markers. - Updated server validation logic to trigger only when silent validation has completed successfully. - Enhanced tests to cover scenarios for validateOn='blur' and validateOn='change', ensuring accurate isValid state tracking. - Improved handling of custom validation errors and field change callbacks. - Added new tests for checking context isValid with various validation settings and user interactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
isValidlogic forCommandFormin @cratis/arc.react to make it more consistent. It fixes cases where theisValidwas becoming true after a single field becoming valid while the rest weren't.