Fix http_date function to correctly handle UTC time#5
Merged
tyomo4ka merged 5 commits intoCoverGenius:masterfrom Apr 10, 2025
Merged
Conversation
added 5 commits
April 8, 2025 23:01
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
==========================================
- Coverage 95.47% 95.43% -0.05%
==========================================
Files 7 7
Lines 221 219 -2
==========================================
- Hits 211 209 -2
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@tyomo4ka had to push some substantial updates to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
http_date()function in xcover/utils.py incorrectly usedmktime()to convert UTC time to a timestamp. Sincemktime()interprets time tuples as local time, this caused the date header to be off by the local timezone offset (e.g., UTC+10 for Sydney). This resulted in authentication failures when clients were in different timezones.In addition, the
datetime.utcnow()is now deprecated and will be removed in a future version.Solution
datetime.utcnow()with the timezone-awaredatetime.now(timezone.utc)strftime()instead ofmktime()andformat_date_time()Changes
http_date()function in xcover/utils.py to correctly handle UTC timeTesting
datetime.now()withtimezone.utc