Open
Conversation
WattsUp
requested changes
Mar 10, 2020
Member
WattsUp
left a comment
WattsUp
left a comment
There was a problem hiding this comment.
- Is there a reason for not implementing as a class with member functions?
- Prefer to use ints with specified bit length
- There are a lot of magic numbers...
- Have you tested this?
- What happens on edge cases? Does the checksum make sure that when you atoi you don't have letters? What if the string is not null terminated?
- return mbed_error_status_t not int
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a function for parsing data structures and struct for holding the data.