Open
Conversation
Added crc described in protocol to CISLibrary/tools
Shade-MC
requested review from
GabeAdamson,
WattsUp,
dcheatha and
warior4356
dcheatha
approved these changes
Feb 17, 2020
WattsUp
requested changes
Feb 18, 2020
Member
WattsUp
left a comment
WattsUp
left a comment
There was a problem hiding this comment.
- The CRC function should be able to add single bytes to support use in communications. also CRC32, also lookup table to be faster
- Save the word document to git too (pop it in a 'native' folder)
- There should only exist one version of the document. Add a link to replace the IHU folder if you want (at least delete the IHU folder one).
- The interface specifies the format of the 8byte structure but lacks commands. What are the actual commands you use?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added crc described in protocol to CISLibrary/tools
Added new communication protocol to ADCS and IHU src docs