Open
Conversation
Manuthor
force-pushed
the
fix/systemd_mitigations
branch
from
2094255 to
df1010c
Compare
Manuthor
force-pushed
the
fix/systemd_mitigations
branch
from
df1010c to
003deb3
Compare
Manuthor
force-pushed
the
fix/systemd_mitigations
branch
from
a011b8c to
c064695
Compare
When a volume bind-mount targets /etc/cosmian/kms.toml and the parent directory does not exist in the image, Docker creates the mount-point as a directory instead of a file. The KMS server was using Path::exists() to detect config files, which returns true for directories, causing a fatal "Is a directory" error when it tried to read_to_string the path. Two complementary fixes: - clap_config.rs: replace exists() with is_file() for all three config path checks (-c/--config, COSMIAN_KMS_CONF, default path). A path that exists but is not a regular file now emits a clear warning and falls through rather than crashing. - docker.nix: pre-create /etc/cosmian/ in fakeRootCommands so Docker bind-mounts of config files land as regular files in the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #710