Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for AWS XKS (External Key Store) v2, enabling the KMS server to act as an XKS proxy that integrates with AWS KMS. The implementation includes AWS SigV4 authentication middleware, health status monitoring, key metadata retrieval, and encrypt/decrypt operations.
Key changes:
- Added AWS XKS configuration options and parameter structures
- Implemented SigV4 authentication middleware for AWS requests
- Added XKS API endpoints (health status, key metadata, encrypt, decrypt)
- Updated Rust toolchain from 1.90.0 to 1.91.0
Reviewed changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Updated Rust version to 1.91.0 |
| crate/server/src/routes/aws_xks/* | New AWS XKS implementation including middleware, endpoints, and error handling |
| crate/server/src/config/* | Added AWS XKS configuration parameters |
| crate/server/src/core/operations/{encrypt,decrypt}.rs | Improved error handling to distinguish between authorization and not-found errors |
| crate/server/src/start_kms_server.rs | Integrated AWS XKS service endpoints into server |
| Cargo.toml | Added new dependencies for AWS signature verification and HTTP handling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check PR review below for a description