Implement Covercrypt CCA#136
Merged
tbrezot merged 6 commits intofeat/check_ap_homogeneityfrom Jun 11, 2024
Merged
Conversation
Adamk93
approved these changes
Jun 6, 2024
Contributor
Adamk93
left a comment
There was a problem hiding this comment.
Honestly for me is good! I don't see anything to complain about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Covercrypt CCA as described in the latest version of the Covercrypt paper.
Changes
kyber::SecretKeycan extract thekyber::PublicKeyfrom within itself;ElGamal::Scalaris stored instead of the key-pair, this means that a boolean storing the activation status needs to be added (this information was previously contained by the presence of theelgamal::EcPoint);tagand outputseedare generated from hashing both the encapsulated seed and the encapsulations (theeakem_hash!macro is removed);Encapsulationtherefore replaces theHashSetby aVecin order to conserve this order through serialization;EAtrait was modified to reorder parameters in a more usual fashion andEA::decryptnow returns aZeroizing<Vec<u8>>instead of a plainVec<u8>.Impact on performances and sizes
Note: The impact of the increased hashing time should be negligible and the encryption upon decryption should not be predominant. However, the benchmarks need to be added again in order to quantify the performance degradation.