Updates to the C# Koans based on experiences with ~50 students#6
Open
elizamarcum wants to merge 14 commits intoCoryFoy:masterfrom
Open
Updates to the C# Koans based on experiences with ~50 students#6elizamarcum wants to merge 14 commits intoCoryFoy:masterfrom
elizamarcum wants to merge 14 commits intoCoryFoy:masterfrom
Conversation
My students found it quite confusing to have the assertions in the body of another method.
… me` for clarity
…Koans out loud. Also, it just makes a little more sense this way.
…e they are used in the Extension Methods.
Because, fail they will.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've used the DotNetKoans to teach two of my classes the basics of C#. During the most recent class, I took careful note of the issues they ran into, so that I could contribute back fixes for future learners.
This pull request is fairly epic, and I understand if you don't want to merge in all of these changes. In particular, I'm not sure you'll want the changes to the .Net version. I was careful to keep the commits both topical and atomic, so I can easily remove any changes you don't want to merge in.
Thanks for your work on the DotNetKoans!