[Issue #57] Thorough cleanup of unused dependencies#132
[Issue #57] Thorough cleanup of unused dependencies#132LorenzoTettamanti merged 5 commits intoCortexFlow:PreReleaseMainfrom
Conversation
- Removed serde_yaml: not used in codebase - Removed tokio: not directly used in CLI code - Removed tokio-stream: not used in CLI This cleanup reduces build times and dependency bloat as part of issue CortexFlow#57. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Removed serde_yaml: not used in codebase Removed tokio: not directly used in CLI code Removed tokio-stream: not used in CLI This cleanup reduces build times and dependency bloat as part of issue CortexFlow#57.
|
Leaving this here until further testing, any feedback is appreciated. First EDIT: I planned my os switch in the next 2/3 weeks to Linux couse of EOS of win10, but until then i can't fully check the compiling, aya/eBPF is obviously not available on WinOS, until then this might have to wait or be manually tested by maintainers. Andrea |
- Restored serde_yaml: used in essential.rs for config handling - Restored tokio: required for async functionality - Removed only tokio-stream: actually unused in CLI code - Updated Cargo.lock with correct dependencies This corrects the previous overly aggressive dependency removal. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- network-types dependency was not used in any source files - Only found in auto-generated bindings.rs as field names, not imports - This completes the thorough dependency cleanup across all components 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
AndreaBozzo
changed the title
LorenzoTettamanti
left a comment
LorenzoTettamanti
left a comment
There was a problem hiding this comment.
Hi Andrea, thanks for your project review. You did a great job removing all the unused/old crates and dependencies. Can you also modify this file?
https://github.com/CortexFlow/CortexBrain/blob/PreReleaseMain/core%2FReadme.md
Thanks 🙏🏻,
Lorenzo
- Remove unused entries from .gitignore as requested - Update core/Readme.md to reflect only existing components - Remove references to non-implemented Loadbalancer, Maps, and XDP components 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
.gitignore and README briefly updated as requested by Lorenzo I'll be around if you need. |
|
Thanks @AndreaBozzo , unfortunately right now I can't test the building process because i'm experiencing some network issues. Maybe @siddh34 is available to test the pr in the next few days.
|
LorenzoTettamanti
added
code refactoring
|
@AndreaBozzo It's working as expected. I'm merging the changes |
|
Thanks @LorenzoTettamanti for the super quick review and merge! |
2 participants
Summary
This PR addresses issue #57 by removing unused dependencies and cleaning up the codebase after the transition from monolithic to containerized core architecture.
Changes Made
Components Verified
The following components are currently active and documented:
Testing Status
Ready for testing on Linux systems with eBPF support. Windows testing limitations noted due to eBPF unavailability.
🤖 Generated with Claude Code