[1.18.2-2.7.4+] Make sky dark again.#522
[1.18.2-2.7.4+] Make sky dark again.#522ProfessorFartsalot wants to merge 1 commit intoCorosauce:1.18_post_ltfrom
Conversation
This restores compatibility with shaders and custom resource packs so that the sky actually looks like it's storming and raining when a storm is active. Personally I'd like to just see it as 1.0F so that things like Complementary shaders fully cover the built-in cloud layer for the immersion of it actually being a real storm. I don't think we'd see the sun with a F5 tornado on the ground or hailing super-cell :P Even 0.8F would probably be fine. I understand the want for a less dramatic effect but it kind of just makes the mod feel more alive so to speak. Thanks ^_^
|
Note that I'm no professional and also can't code whatsoever, so don't expect me to know anything (I'm honestly still not sure if that means I really shouldn't be on here), but I just want to say that I 100% support this for the same reasons you stated: It would both make the mod feel more alive, and the restoring compatibility thing with shaders and certain resource packs. I also think the increasing darkness values depending on the intensity stage of the storms you mentioned is a good idea. It also makes me wonder if things like this could be made customizable within the config files. This could (purely as a theoretical idea since, once again, I'm just a regular person wanting to have fun while playing modded Minecraft and am by no means a developer) look like having the default values set to Corosus's preferences, while allowing players to set higher values if they like. |
|
It could be made into a configuration easy actually but I don't want to ask too much of him. He only just got it to 1.18 after all and of course these things take time to test and make sure it works^^ |
I understand that. It was more a question about if it was possible or not rather than a request because I don't want to be too pushy or demanding. I also can't control my urge to share ideas sometimes because I can't help that I'm so hyped, haha. But of course that doesn't mean that I'm demanding them to be implemented. |
Of course! It is very good to have him back on 1.18+ |
ProfessorFartsalot
changed the title
|
I'm probably late, but I've been thinking, and since it's known that the change was intentional and also that this pull request has been made, shouldn't I have closed the issue I wrote a while ago? |
|
I'd wait and see if @Corosauce sees this ^^ |
|
this looks really good :0 so if i want the tornadoes to look like this which version should i use? hope it gets fixed / added again |
|
I'd use 2.7.1 for now |
|
oks, and do u know if that version works well on servers like aternos? cuz seems like the latest ver fixed something related to servers |
|
@KarinMiku I am sorry for the very very late reply (my god it's been 6 months @_@) but the latest 1.18 update should fix the tornadoes to look dark like this in a storm. Doubtless you've already tested it out though eheh. The latest update also fixed configs resetting. Life kinda stacked up on me for a bit and now im back on a github committing spree XD |
3 participants
This restores compatibility with shaders and custom resource packs so that the sky actually looks like it's storming and raining when a storm is active.
Personally I'd like to just see it as 1.0F so that things like Complementary shaders fully cover the built-in cloud layer for the immersion of it actually being a real storm. I don't think we'd see the sun with a F5 tornado on the ground or hailing super-cell :P
I understand the want for a less dramatic effect but 1.0F kind of just makes the mod feel more alive so to speak, as you can see in these below screenshots comparing the two floats. Of course, it may also be reasonable to have the sky darken depending on if it's a rain storm, thunderstorm, or supercell. 0.5F if rain storm, 0.75F if thunderstorm, 1.0F if wind storm or above. Thanks! ^_^
Darkness 0.5F - Sun is visible, not common for a tornadic supercell:
Darkness 1.0F - Looks more like a real supercell:
Edit: words are hard >.>, am not good at this github thing yet eheh