Fix for CWE-601: URL Redirection to Untrusted Site ('Open Redirect') #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐕 Corgea issued a PR to fix a vulnerability found in data/static/codefixes/redirectCryptoCurrencyChallenge_4.ts.
It is CWE-601: URL Redirection to Untrusted Site ('Open Redirect') that has a severity of 🔴 High.
🪄 Fix explanation
The fix changes the URL comparison from using "includes" to strict equality, ensuring only exact matches from the allowlist are permitted, thus preventing open redirects to untrusted sites.
- The original code used "url.includes(allowedUrl)", which allowed partial matches, enabling potential redirects to malicious sites.
- The fix replaces "includes" with "===", ensuring only exact URL matches from the "redirectAllowlist" are allowed.
- This change prevents attackers from exploiting partial URL matches to redirect users to untrusted sites.
- The "redirectAllowlist" must contain only fully trusted URLs to ensure security.
💡 Important Instructions
Ensure the
redirectAllowlistis populated with complete and trusted URLs only, as partial matches are no longer valid.See the issue and fix in Corgea.