Fix for CWE-116: Improper Encoding or Escaping of Output #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐕 Corgea issued a PR to fix a vulnerability found in frontend/src/app/last-login-ip/last-login-ip.component.ts.
It is CWE-116: Improper Encoding or Escaping of Output that has a severity of 🔴 Critical.
🪄 Fix explanation
The fix removes the use of "bypassSecurityTrustHtml", which improperly trusted unescaped HTML content, and directly assigns the IP address to "lastLoginIp", preventing potential script injection.
- The original code used "bypassSecurityTrustHtml" to render HTML, which could allow script injection if the input was not sanitized.
- The fix directly assigns "payload.data.lastLoginIp" to "this.lastLoginIp", avoiding the creation of HTML content.
- By removing HTML rendering, the fix ensures that the IP address is treated as plain text, mitigating the risk of executing malicious scripts.
💡 Important Instructions
Ensure that
payload.data.lastLoginIpis validated as a legitimate IP address format before assignment to prevent any unexpected input handling.See the issue and fix in Corgea.