Fix for CWE-116: Improper Encoding or Escaping of Output #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐕 Corgea issued a PR to fix a vulnerability found in frontend/src/app/about/about.component.ts.
It is CWE-116: Improper Encoding or Escaping of Output that has a severity of 🔴 Critical.
🪄 Fix explanation
The fix removes the use of "bypassSecurityTrustHtml", ensuring that user comments are safely bound in the template without bypassing Angular's built-in security mechanisms, thus preventing potential XSS attacks.
- The line "feedbacks[i].comment = this.sanitizer.bypassSecurityTrustHtml(feedbacks[i].comment)" is removed to prevent bypassing Angular's security.
- Comments are now directly bound in the template, leveraging Angular's automatic HTML escaping to prevent XSS.
- The fix ensures that any HTML content in "feedbacks[i].comment" is treated as plain text, preserving the intended structure.
💡 Important Instructions
Ensure that the template where
feedbacks[i].commentis used is properly configured to bind the comment safely, using Angular's data binding syntax.See the issue and fix in Corgea.