fix: skip per-tick stale recovery for local workers#233
Open
tyxben wants to merge 1 commit intoConway-Research:mainfrom
Open
fix: skip per-tick stale recovery for local workers#233tyxben wants to merge 1 commit intoConway-Research:mainfrom
tyxben wants to merge 1 commit intoConway-Research:mainfrom
Conversation
Local workers are in-process async tasks that remove themselves from the activeWorkers map on completion. The per-tick stale recovery (introduced in e099808) treats this as a dead worker and resets the task to pending, causing an infinite assign→complete→reset loop that burns ~$0.03/turn. Fix: 1. Skip local:// workers in per-tick stale recovery (remote only) 2. Add one-time startup recovery for local workers (process restart) 3. Validate goalId in loadState — reset if goal is completed/cancelled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression from #227 where the per-tick stale recovery causes an infinite loop for local workers:
activeWorkerson completionChanges
local://workers in per-tick stale recovery (orchestrator.ts) — only check remote sandbox workersloop.ts) — on process restart, reset stalelocal://assigned tasks once (not every tick)loadState(orchestrator.ts) — if persisted goal is completed/cancelled/missing, reset to idleTest plan
pnpm typecheckpasses