Skip to content

Conversation

@ozakernychnyi
Copy link

No description provided.

Copy link

@lkumarjain lkumarjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this replace needed in the core library... shouldn't it be done in the consumer project

@ozakernychnyi
Copy link
Author

ozakernychnyi commented Sep 15, 2023

Why is this replace needed in the core library... shouldn't it be done in the consumer project

So we have done this because we have the same in other forks, for example:
https://github.com/ContinuumLLC/hystrix-go/blob/master/go.mod#L13
https://github.com/ContinuumLLC/go-zookeeper/blob/master/go.mod#L5

Why do we need this, just to avoid this replacement declaration in all of the go.mod files which reference to this library.
Its pretty unobvious why should I add replacement statement when I try to import this library.
Live example:
I've added this replacement into common-lib by my need.
But when I want to refer to this library version in another project i should add this replacement also. This is something hidden from first look. I guess we shouldn't handle all the replacement coming from other libs. It should be done under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants