This repository was archived by the owner on Jun 22, 2018. It is now read-only.
Plugin does not work if docker uses TLS#534
Open
Igosuki wants to merge 7 commits intoContainerSolutions:masterfrom
Igosuki:master
Open
Plugin does not work if docker uses TLS#534Igosuki wants to merge 7 commits intoContainerSolutions:masterfrom Igosuki:master
Igosuki wants to merge 7 commits intoContainerSolutions:masterfrom
Igosuki:master
Conversation
Contributor
|
@Igosuki Thanks for this PR! The build fails however because of a failing test. See https://travis-ci.org/ContainerSolutions/minimesos/builds/233244362?utm_source=github_status&utm_medium=notification. Run |
Contributor
|
@Igosuki It seems that now the Docker client is configured to always use TLS verification. Can you change the code so it only does this when the |
Author
|
Alright looks like it's still not passing for some reason, will check later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can change the code to make tls verify a condition if you want