This repository was archived by the owner on Jun 22, 2018. It is now read-only.
Open
Conversation
This patch change the base image for minimesos to alpine:3.5 Alpine is now packaging docker, no need to download it through curl Install openjdk-jre-base instead of full version (save ~30MB) Image size is reduced by about 20% (265MB to 215MB) this reduce build and download time.
Contributor
|
I am afraid this change breaks support for Docker on Mac. If you have a solution that uses Alpine + Docker on Mac that would be even better! |
Contributor
Author
|
Sadly I can't test it, but I though this wouldn't break anything as the base image of the previous container was also an alpine linux (see here) Can you provide me some logs or error messages so I can try fixing this or at least understand the difference between docker and docker-machine on OSX? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch change the base image for minimesos to alpine:3.5
Alpine is now packaging docker, no need to download it through curl
Install openjdk-jre-base instead of full version (save ~30MB)
Image size is reduced by about 20% (265MB to 215MB) this reduce
build and download time.