Download COS kernel archive at specified commit#13
Download COS kernel archive at specified commit#13Amey-D wants to merge 1 commit intoContainerEngine:masterfrom
Conversation
Instead of `git pull`ing the sources this PR utilizes gitiles' feature to download the source tarball at the specified commit. This also removes `git clone` from the Dockerfile.
rohitagarwal003
left a comment
rohitagarwal003
left a comment
There was a problem hiding this comment.
$ time curl -sS "${download_url}" -o "${archive_filename}"
real 1m10.413s
user 0m0.829s
sys 0m1.958s
$ time tar xf "${archive_filename}"
real 0m9.957s
user 0m2.494s
sys 0m7.319s
I don't think this added latency on node bring up is going to work.
| fi | ||
| local -r download_url = "https://chromium.googlesource.com/chromiumos/third_party/kernel/+archive/${LAKITU_KERNEL_SHA1}.tar.gz" | ||
| local -r archive_filename = "cos-kernel.tar.gz" | ||
| until curl -sS "${download_url}" -o "${archive_filename}" |
There was a problem hiding this comment.
I tried this command without setting LAKITA_KERNEL_SHA and it still passed.
|
Is there a way we can measure e2e latency on GCE? Presumably with this PR the Docker container would also become smaller so |
Unfortunately, there's no good way to easily do it.
Good point. However, I am still very much against putting chromium's git infrastructure in the node bring up critical path. GCR is designed for such things and has SLAs etc. Chromium's git infrastructure is not designed for this and may get overwhelmed by this. Imagine someone starting this DaemonSet on a 100 node cluster. |
2 participants
Instead of
git pulling the sources this PR utilizes gitiles' featureto download the source tarball at the specified commit. This also
removes
git clonefrom the Dockerfile.